diff options
author | hop311 <hop3114@gmail.com> | 2024-01-22 17:32:18 +0100 |
---|---|---|
committer | hop311 <hop3114@gmail.com> | 2024-01-22 17:32:18 +0100 |
commit | fe1938484ab359fb76712cb59a43830e6f852f00 (patch) | |
tree | 9ac450512b18730461c4eaeb3af29b03da6f9b71 /src/openvic-dataloader/detail/Warnings.hpp | |
parent | 77167fe3366b40b74abff45bcb62f7480963d617 (diff) |
Fixed BasicParser::_file_path relying on externally controlled memoryfix/file-path-memory
Diffstat (limited to 'src/openvic-dataloader/detail/Warnings.hpp')
-rw-r--r-- | src/openvic-dataloader/detail/Warnings.hpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/openvic-dataloader/detail/Warnings.hpp b/src/openvic-dataloader/detail/Warnings.hpp index 6c0b34e..8fc09bd 100644 --- a/src/openvic-dataloader/detail/Warnings.hpp +++ b/src/openvic-dataloader/detail/Warnings.hpp @@ -1,13 +1,15 @@ #pragma once -#include <openvic-dataloader/v2script/Parser.hpp> +#include <string_view> + +#include <openvic-dataloader/ParseWarning.hpp> namespace ovdl::v2script::warnings { - inline const ParseWarning make_utf8_warning(const char* file_path) { + inline const ParseWarning make_utf8_warning(std::string_view file_path) { constexpr std::string_view message_suffix = "This may cause problems. Prefer Windows-1252 encoding."; std::string message; - if (!file_path) { + if (file_path.empty()) { message = "Buffer is a UTF-8 encoded string. " + std::string(message_suffix); } else { message = "File '" + std::string(file_path) + "' is a UTF-8 encoded file. " + std::string(message_suffix); |