Merge pull request #39 from OpenVicProject/cleanup

Cleanup

1 files changed, 14 insertions, 14 deletions

diff --git a/src/openvic-simulation/politics/Issue.hpp b/src/openvic-simulation/politics/Issue.hpp
index 66e8d1a..ddd6295 100644
--- a/src/openvic-simulation/politics/Issue.hpp
+++ b/src/openvic-simulation/politics/Issue.hpp
@@ -14,7 +14,7 @@ namespace OpenVic {
 		friend struct IssueManager;
 
 	protected:
-		IssueGroup(const std::string_view identifier);
+		IssueGroup(std::string_view identifier);
 
 	public:
 		IssueGroup(IssueGroup&&) = default;
@@ -30,7 +30,7 @@ namespace OpenVic {
 		//TODO: policy modifiers, policy rule changes
 
 	protected:
-		Issue(const std::string_view identifier, IssueGroup const& group);
+		Issue(std::string_view identifier, IssueGroup const& group);
 
 	public:
 		Issue(Issue&&) = default;
@@ -45,7 +45,7 @@ namespace OpenVic {
 		bool uncivilised; //whether this group is available to non-westernised countries
 		//in vanilla education, military and economic reforms are hardcoded to true and the rest to false
 
-		ReformType(const std::string_view new_identifier, bool uncivilised);
+		ReformType(std::string_view new_identifier, bool uncivilised);
 
 	public:
 		ReformType(ReformType&&) = default;
@@ -60,7 +60,7 @@ namespace OpenVic {
 		const bool ordered; //next_step_only
 		const bool administrative;
 
-		ReformGroup(const std::string_view identifier, ReformType const& type, bool ordered, bool administrative);
+		ReformGroup(std::string_view identifier, ReformType const& type, bool ordered, bool administrative);
 
 	public:
 		ReformGroup(ReformGroup&&) = default;
@@ -77,7 +77,7 @@ namespace OpenVic {
 		ReformGroup const& reform_group; //stores an already casted reference
 		const size_t ordinal; //assigned by the parser to allow policy sorting
 
-		Reform(const std::string_view new_identifier, ReformGroup const& group, size_t ordinal);
+		Reform(std::string_view new_identifier, ReformGroup const& group, size_t ordinal);
 
 		//TODO: conditions to allow,
 
@@ -97,28 +97,28 @@ namespace OpenVic {
 		IdentifierRegistry<ReformGroup> reform_groups;
 		IdentifierRegistry<Reform> reforms;
 
-		bool _load_issue_group(size_t& expected_issues, const std::string_view identifier, ast::NodeCPtr node);
-		bool _load_issue(const std::string_view identifier, IssueGroup const* group, ast::NodeCPtr node);
-		bool _load_reform_group(size_t& expected_reforms, const std::string_view identifier, ReformType const* type,
+		bool _load_issue_group(size_t& expected_issues, std::string_view identifier, ast::NodeCPtr node);
+		bool _load_issue(std::string_view identifier, IssueGroup const* group, ast::NodeCPtr node);
+		bool _load_reform_group(size_t& expected_reforms, std::string_view identifier, ReformType const* type,
 			ast::NodeCPtr node);
-		bool _load_reform(size_t& ordinal, const std::string_view identifier, ReformGroup const* group, ast::NodeCPtr node);
+		bool _load_reform(size_t& ordinal, std::string_view identifier, ReformGroup const* group, ast::NodeCPtr node);
 
 	public:
 		IssueManager();
 
-		bool add_issue_group(const std::string_view identifier);
+		bool add_issue_group(std::string_view identifier);
 		IDENTIFIER_REGISTRY_ACCESSORS(IssueGroup, issue_group)
 
-		bool add_issue(const std::string_view identifier, IssueGroup const* group);
+		bool add_issue(std::string_view identifier, IssueGroup const* group);
 		IDENTIFIER_REGISTRY_ACCESSORS(Issue, issue)
 
-		bool add_reform_type(const std::string_view identifier, bool uncivilised);
+		bool add_reform_type(std::string_view identifier, bool uncivilised);
 		IDENTIFIER_REGISTRY_ACCESSORS(ReformType, reform_type)
 
-		bool add_reform_group(const std::string_view identifier, ReformType const* type, bool ordered, bool administrative);
+		bool add_reform_group(std::string_view identifier, ReformType const* type, bool ordered, bool administrative);
 		IDENTIFIER_REGISTRY_ACCESSORS(ReformGroup, reform_group)
 
-		bool add_reform(const std::string_view identifier, ReformGroup const* group, size_t ordinal);
+		bool add_reform(std::string_view identifier, ReformGroup const* group, size_t ordinal);
 		IDENTIFIER_REGISTRY_ACCESSORS(Reform, reform)
 
 		bool load_issues_file(ast::NodeCPtr root);