3 files changed, 135 insertions, 0 deletions

diff --git a/src/openvic-simulation/military/LeaderTrait.cpp b/src/openvic-simulation/military/LeaderTrait.cpp
new file mode 100644
index 0000000..27f81c5
--- /dev/null
+++ b/src/openvic-simulation/military/LeaderTrait.cpp
@@ -0,0 +1,60 @@
+#include "LeaderTrait.hpp"
+
+using namespace OpenVic;
+using namespace OpenVic::NodeTools;
+
+LeaderTrait::LeaderTrait(std::string_view new_identifier, trait_type_t new_type, ModifierValue new_modifiers)
+    : HasIdentifier { new_identifier }, type { new_type }, modifiers { new_modifiers } {}
+
+trait_type_t LeaderTrait::get_trait_type() const {
+    return type;
+}
+
+bool LeaderTrait::is_personality_trait() const {
+    return type == trait_type_t::PERSONALITY;
+}
+
+bool LeaderTrait::is_background_trait() const {
+    return type == trait_type_t::BACKGROUND;
+}
+
+ModifierValue LeaderTrait::get_modifiers() const {
+    return modifiers;
+}
+
+LeaderTraitManager::LeaderTraitManager() : leader_traits { "leader_traits" } {}
+
+bool LeaderTraitManager::add_leader_trait(std::string_view identifier, trait_type_t type, ModifierValue modifiers) {
+    if (identifier.empty()) {
+        Logger::error("Invalid leader trait identifier - empty!");
+        return false;
+    }
+
+    return leader_traits.add_item({ identifier, type, modifiers });
+}
+
+bool LeaderTraitManager::load_leader_traits_file(ModifierManager& modifier_manager, ast::NodeCPtr root) {
+    bool ret = expect_dictionary_keys(
+        "personality", ONE_EXACTLY, expect_dictionary(
+            [this, &modifier_manager](std::string_view trait_identifier, ast::NodeCPtr value) -> bool {
+                ModifierValue modifiers;
+
+                bool ret = modifier_manager.expect_whitelisted_modifier_value(move_variable_callback(modifiers), allowed_modifiers)(value);
+                ret &= add_leader_trait(trait_identifier, trait_type_t::PERSONALITY, modifiers);
+                return ret;
+            }
+        ),
+        "background", ONE_EXACTLY, expect_dictionary(
+            [this, &modifier_manager](std::string_view trait_identifier, ast::NodeCPtr value) -> bool {
+                ModifierValue modifiers;
+
+                bool ret = modifier_manager.expect_whitelisted_modifier_value(move_variable_callback(modifiers), allowed_modifiers)(value);
+                ret &= add_leader_trait(trait_identifier, trait_type_t::BACKGROUND, modifiers);
+                return ret;
+            }
+        )
+    )(root);
+    lock_leader_traits();
+
+    return ret;
+}
\ No newline at end of file
diff --git a/src/openvic-simulation/military/LeaderTrait.hpp b/src/openvic-simulation/military/LeaderTrait.hpp
new file mode 100644
index 0000000..f4445f6
--- /dev/null
+++ b/src/openvic-simulation/military/LeaderTrait.hpp
@@ -0,0 +1,72 @@
+#pragma once
+
+#include <cstdint>
+#include <string_view>
+#include "openvic-simulation/types/IdentifierRegistry.hpp"
+#include "openvic-simulation/types/fixed_point/FixedPoint.hpp"
+#include "openvic-simulation/dataloader/NodeTools.hpp"
+#include "openvic-simulation/Modifier.hpp"
+
+namespace OpenVic {
+    struct LeaderTraitManager;
+
+    enum class trait_type_t {
+        PERSONALITY,
+        BACKGROUND
+    };
+
+    struct LeaderTrait : HasIdentifier {
+        friend struct LeaderTraitManager;
+
+    private:
+
+        const trait_type_t type;
+        /* 
+         * Allowed modifiers for leaders:
+         * attack - integer
+         * defence - integer
+         * morale - %
+         * organisation - %
+         * reconnaissance - %
+         * speed - %
+         * attrition - %, negative is good
+         * experience - %
+         * reliability - decimal, mil gain or loss for associated POPs
+         */
+        const ModifierValue modifiers;
+
+        LeaderTrait(std::string_view new_identifier, trait_type_t new_type, ModifierValue new_modifiers);
+        
+    public:
+        LeaderTrait(LeaderTrait&&) = default;
+
+        trait_type_t get_trait_type() const;
+        bool is_personality_trait() const;
+        bool is_background_trait() const;
+        ModifierValue get_modifiers() const;
+    };
+
+    struct LeaderTraitManager {
+    private:
+        IdentifierRegistry<LeaderTrait> leader_traits;
+        const std::set<std::string, std::less<void>> allowed_modifiers = {
+            "attack",
+            "defence",
+            "morale",
+            "organisation",
+            "reconnaissance",
+            "speed",
+            "attrition",
+            "experience",
+            "reliability"
+        };
+    
+    public:
+        LeaderTraitManager();
+
+        bool add_leader_trait(std::string_view identifier, trait_type_t type, ModifierValue modifiers);
+        IDENTIFIER_REGISTRY_ACCESSORS(leader_trait)
+
+        bool load_leader_traits_file(ModifierManager& modifier_manager, ast::NodeCPtr root);
+    };
+} // namespace OpenVic
diff --git a/src/openvic-simulation/military/MilitaryManager.hpp b/src/openvic-simulation/military/MilitaryManager.hpp
index 36b5010..fd8135d 100644
--- a/src/openvic-simulation/military/MilitaryManager.hpp
+++ b/src/openvic-simulation/military/MilitaryManager.hpp
@@ -1,12 +1,15 @@
 #pragma once
 
 #include "openvic-simulation/military/Unit.hpp"
+#include "openvic-simulation/military/LeaderTrait.hpp"
 
 namespace OpenVic {
 	struct MilitaryManager {
 	private:
 		UnitManager unit_manager;
+		LeaderTraitManager leader_trait_manager;
 	public:
 		REF_GETTERS(unit_manager)
+		REF_GETTERS(leader_trait_manager)
 	};
 }