diff options
author | Spartan322 <Megacake1234@gmail.com> | 2023-05-20 10:39:37 +0200 |
---|---|---|
committer | Spartan322 <Megacake1234@gmail.com> | 2023-05-20 10:39:37 +0200 |
commit | 3bf63f1615868cb4a8625356a49eff4aed36879c (patch) | |
tree | 54d7092a3f68740e92008e073334d6beb3154a8b /game/src/OptionMenu/GuiScaleSelector.gd | |
parent | e80966ad4d92599bd5f899dfa708d2e6d131b7e7 (diff) |
Add revert dialog functionality to ScreenModeSelector
Fix recursion bug caused by invalid default value in `reset_setting`
Add `option_selected` signal to SettingOptionButton
Allows discerning between user option selection and system option selection
Add `no_emit` bool defaulted to false for `SettingOptionButton.reset_setting`
Add push_error for failing to generate option as well
Generalize ResolutionRevertDialog functionality
Using the `dialog_reverted` signal enables custom revert functionality instead
Disables process function while not visible
Displayed time is more correct
Add Resolution `resolution_added`, `resolution_changed`, and `window_mode_changed` signals
Add `get_resolution_name` to Resolution
Change ResolutionSelector `_sync_resolutions` to use `Resolution.resolution_added` signal
Reduces unnecessary resolution option list rebuilds
Move Resolution display_name functionality to ResolutionSelector
Makes it easier to denote default functionality an inline fashion
Add SettingRevertButton to automatically handle revert setting behavior
Rename VideoTab VBoxContainer/GridContainer to VideoSettingGrid
Rename VideoTab VBoxContainer to VideoSettingList
Remove `horizontal_alignment` from AutosaveIntervalLabel
Diffstat (limited to 'game/src/OptionMenu/GuiScaleSelector.gd')
-rw-r--r-- | game/src/OptionMenu/GuiScaleSelector.gd | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/game/src/OptionMenu/GuiScaleSelector.gd b/game/src/OptionMenu/GuiScaleSelector.gd index 6593a07..4dd86e1 100644 --- a/game/src/OptionMenu/GuiScaleSelector.gd +++ b/game/src/OptionMenu/GuiScaleSelector.gd @@ -56,9 +56,9 @@ func _set_value_from_file(load_value): push_error("Setting value '%s' invalid for setting [%s] %s" % [load_value, section_name, setting_name]) selected = default_selected -func _on_item_selected(index:int): +func _on_option_selected(index : int, by_user : bool): if _valid_index(index): GuiScale.set_guiscale(get_item_metadata(index)) else: push_error("Invalid GuiScaleSelector index: %d" % index) - reset_setting() + reset_setting(not by_user) |