From bcd60b398c4d518c188dccf535f0d0b330ae2cf2 Mon Sep 17 00:00:00 2001 From: Spartan322 Date: Tue, 16 May 2023 15:19:40 -0400 Subject: Fix SettingHSlider not loading properly on default values Fixes volume sliders being ignored when loaded at zero Fix MusicConductor ignoring MUSIC_BUS --- game/src/MusicConductor/MusicConductor.tscn | 2 +- game/src/OptionMenu/SettingNodes/SettingHSlider.gd | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/game/src/MusicConductor/MusicConductor.tscn b/game/src/MusicConductor/MusicConductor.tscn index 7194f0b..182de99 100644 --- a/game/src/MusicConductor/MusicConductor.tscn +++ b/game/src/MusicConductor/MusicConductor.tscn @@ -8,6 +8,6 @@ music_directory = "res://audio/music" first_song_name = "The_Crown" [node name="AudioStreamPlayer" type="AudioStreamPlayer" parent="."] -bus = &"Music" +bus = &"MUSIC_BUS" [connection signal="finished" from="AudioStreamPlayer" to="." method="_on_audio_stream_player_finished"] diff --git a/game/src/OptionMenu/SettingNodes/SettingHSlider.gd b/game/src/OptionMenu/SettingNodes/SettingHSlider.gd index 4e7c9c9..6fa30ed 100644 --- a/game/src/OptionMenu/SettingNodes/SettingHSlider.gd +++ b/game/src/OptionMenu/SettingNodes/SettingHSlider.gd @@ -20,12 +20,15 @@ func load_setting(file : ConfigFile): var load_value = file.get_value(section_name, setting_name, default_value) match typeof(load_value): TYPE_FLOAT, TYPE_INT: + if value == load_value: value_changed.emit(value) value = load_value return TYPE_STRING, TYPE_STRING_NAME: var load_string := load_value as String if load_string.is_valid_float(): - value = load_string.to_float() + load_value = load_string.to_float() + if value == load_value: value_changed.emit(value) + value = load_value return push_error("Setting value '%s' invalid for setting [%s] \"%s\"" % [load_value, section_name, setting_name]) value = default_value -- cgit v1.2.3-56-ga3b1