From 18ff6fb2fa03335d8a42440aec9f0dcb77f42c3a Mon Sep 17 00:00:00 2001 From: Spartan322 Date: Fri, 30 Jun 2023 18:35:16 -0400 Subject: Update to Godot 4.1 Stable Release Fix deferred error in LoadingScreen.update_loading_screen Fix pressed shadow variable warning in SettingCheckBox.gd --- game/src/Game/LoadingScreen.gd | 2 ++ game/src/Game/Menu/OptionMenu/SettingNodes/SettingCheckBox.gd | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) (limited to 'game/src/Game') diff --git a/game/src/Game/LoadingScreen.gd b/game/src/Game/LoadingScreen.gd index 14acbd7..9d44b41 100644 --- a/game/src/Game/LoadingScreen.gd +++ b/game/src/Game/LoadingScreen.gd @@ -8,6 +8,8 @@ var loadthread: Thread var quotes: PackedStringArray = [] func update_loading_screen(percent_complete: int, quote_should_change = false): + # forces the function to behave as if deferred + await get_tree().process_frame progress_bar.value = percent_complete if quote_should_change: quote_label.text = quotes[randi() % quotes.size()] diff --git a/game/src/Game/Menu/OptionMenu/SettingNodes/SettingCheckBox.gd b/game/src/Game/Menu/OptionMenu/SettingNodes/SettingCheckBox.gd index fcc411e..344a2b5 100644 --- a/game/src/Game/Menu/OptionMenu/SettingNodes/SettingCheckBox.gd +++ b/game/src/Game/Menu/OptionMenu/SettingNodes/SettingCheckBox.gd @@ -19,7 +19,7 @@ func _ready(): Events.Options.load_settings.connect(load_setting) Events.Options.save_settings.connect(save_setting) Events.Options.reset_settings.connect(reset_setting) - toggled.connect(func(pressed : bool): option_selected.emit(pressed, true)) + toggled.connect(func(p : bool): option_selected.emit(p, true)) _setup_button() func _set_value_from_file(load_value) -> void: -- cgit v1.2.3-56-ga3b1